IOS/ES: Fix crash when deleting tickets #11592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke formatting the system memory; see https://bugs.dolphin-emu.org/issues/13176. After calling
ticket.DeleteTicket()
,ticket.m_bytes
was 0-length, but callingticket.IsV1Ticket()
still attempted to read from m_bytes.This was introduced in 2fd9852 (#11240), although it didn't actually cause a crash until 929fba0 (#11383).
I'm not 100% sure if deleting a V1 ticket requires special logic (probably not), or if the process of deleting a V1 ticket could convert it into a V0 ticket somehow (I added an assertion for this). @noahpistilli may know more.